Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#prepareStat() breaks consistent Stat structure #37

Closed
Sayakie opened this issue Apr 11, 2022 · 1 comment
Closed

#prepareStat() breaks consistent Stat structure #37

Sayakie opened this issue Apr 11, 2022 · 1 comment
Assignees
Milestone

Comments

@Sayakie
Copy link
Owner

Sayakie commented Apr 11, 2022

Reproduce steps

If the given stat does not have a forms property or which equivalent to an empty object, the method early returns without overwriting bounding_box to boundingBox.

function prepareStat(stat: Stat): Stat {
if (!stat.forms || Object.keys(stat.forms).length <= 0) {
return stat
}

@Sayakie Sayakie added this to the Hakase v0.2 milestone Apr 11, 2022
@Sayakie Sayakie self-assigned this Apr 11, 2022
@Sayakie
Copy link
Owner Author

Sayakie commented Jul 4, 2022

Close this issue due to the caused method would be deprecated since 1.0

@Sayakie Sayakie closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant