Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "MotionPlanningDisplay: always update query states" #9

Merged
merged 13 commits into from
Jul 31, 2023
Merged

Revert "MotionPlanningDisplay: always update query states" #9

merged 13 commits into from
Jul 31, 2023

Conversation

nyxrobotics
Copy link

@nyxrobotics nyxrobotics commented Jul 24, 2023 •
edited
Loading

This reverts commit d98a529.

Import upstream from origin.

Description

Fixed CPU usage increase after running rviz for a long time

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Document API changes relevant to the user in the moveit/MIGRATION.md notes
  • Created tests, which fail without this PR reference
  • Decide if this should be cherry-picked to other current ROS branches
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@nyxrobotics nyxrobotics marked this pull request as ready for review July 24, 2023 12:53
@nyxrobotics nyxrobotics marked this pull request as draft July 28, 2023 02:30
rhaschke and others added 4 commits July 28, 2023 08:10
@rhaschke
Avoid costly updates of invisible RobotInteractions on query state ch…
e6ef318 
…anges (moveit#3478)

This partially reverts d98a529,
however still updates the query states themselves.
@rhaschke
1.1.13
a9b82cd
@rhaschke
CI: Handle eol distro Melodic
fdc3b1c 
- Add rosdep option --include-eol-distros
- Create moveit:master-ci-testing as alias for master-ci
@david-sperling
Fix typo in create_ikfast_moveit_plugin.py (moveit#3479)
1b351dd 
planing_group_name -> planning_group_name
@nyxrobotics
Copy link
Author

nyxrobotics commented Jul 31, 2023 •
edited
Loading

Officials have fixed it and this is what we will use. #3478

@nyxrobotics nyxrobotics marked this pull request as ready for review July 31, 2023 04:08
@nyxrobotics nyxrobotics requested a review from Tacha-S July 31, 2023 05:03
@Tacha-S Tacha-S merged commit 3a9e63a into noetic-devel Jul 31, 2023
6 of 9 checks passed
@nyxrobotics nyxrobotics mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tacha-S Tacha-S Tacha-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nyxrobotics @Tacha-S @onionsflying @rhaschke @VideoSystemsTech @david-sperling