Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid costly updates of RobotInteraction on query state changes if they are not shown #3478

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

rhaschke
Copy link
Contributor

This partially reverts d98a529, however, still updates the query states themselves.

…ey are not shown

This partially reverts d98a529,
however still updating the query states themselves.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 63.64% and project coverage change: -0.05% ⚠️

Comparison is base (cfcd5ec) 61.86% compared to head (2bba60a) 61.81%.
Report is 8 commits behind head on noetic-devel.

Additional details and impacted files
@@               Coverage Diff                @@
##           noetic-devel    #3478      +/-   ##
================================================
- Coverage         61.86%   61.81%   -0.05%     
================================================
  Files               385      385              
  Lines             34073    34073              
================================================
- Hits              21077    21059      -18     
- Misses            12996    13014      +18     
Files Changed Coverage Δ
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...t_setup_assistant/src/tools/moveit_config_data.cpp 14.34% <0.00%> (ø)
moveit_core/planning_scene/src/planning_scene.cpp 66.73% <100.00%> (ø)
moveit_core/robot_state/src/robot_state.cpp 54.14% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhaschke rhaschke merged commit e6ef318 into moveit:noetic-devel Jul 28, 2023
7 checks passed
@rhaschke rhaschke deleted the fixup-3263 branch July 28, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant