Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A validation step for generated diagrams and/or an automatic correction for editing is needed #9

Open
ibalaur opened this issue Mar 9, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ibalaur
Copy link
Collaborator

ibalaur commented Mar 9, 2019

Currently, the tool checkes the generated SBGN file using the isValid function from libSBGN (SbgnUtil class). The user can check validity of the biological diagram by using other SBGN-support tools, such as the SBGN-ED -> Tools -> Validate within the VANTED software.
However, integrating a validation step for the generated SBGN biological diagram wuold help user. Also, a correction step during editing (e.g. adding bend points to represent ports automatically) would be of benefit for user's experience.

@ibalaur ibalaur added the enhancement New feature or request label Mar 9, 2019
@ibalaur
Copy link
Collaborator Author

ibalaur commented May 20, 2019

Validation of the SBGN files can be now checked using libSBGN 3.0: https://github.com/sbgn/libsbgn/releases/tag/milestone3.1

ibalaur pushed a commit that referenced this issue May 26, 2019
The converter also validates the generated SBGN file by using high
level validation provided by the libSBGN 3.0 library. (Issue #9)
@ibalaur
Copy link
Collaborator Author

ibalaur commented May 26, 2019

The converter validates now the generated SBGN file by using high level validation provided by the libSBGN 3.0 library: 75cba62.
Please see release https://github.com/sbgn/ySBGN/releases/tag/1.2-alpha/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant