Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated boilerplate across Inference classes: derive from common parent #79

Closed
alvorithm opened this issue Mar 23, 2020 · 0 comments · Fixed by #103
Closed

Repeated boilerplate across Inference classes: derive from common parent #79

alvorithm opened this issue Mar 23, 2020 · 0 comments · Fixed by #103
Assignees
Labels
architecture Internal changes without API consequences

Comments

@alvorithm
Copy link
Contributor

alvorithm commented Mar 23, 2020

Problem

Some of the argument checking across SnpeBase, SNL and SRE is repeated code.

Solution

Refactor that commonality and others into a common parent class, NeuralInference.

Follow-up

Each of SNPE A, B, C only override/define one method: _get_log_prob_proposal_posterior(self, inputs, context, masks); consider dealing with it in SnpeBase directly - unless we dispatch elsewhere on concrete class.

@alvorithm alvorithm added the architecture Internal changes without API consequences label Mar 23, 2020
@alvorithm alvorithm changed the title Repeated construction code in Inference classes - derive from common parent? Repeated boilerplate across Inference classes: derive from common parent Mar 23, 2020
@alvorithm alvorithm linked a pull request Mar 31, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Internal changes without API consequences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants