You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the argument checking across SnpeBase, SNL and SRE is repeated code.
Solution
Refactor that commonality and others into a common parent class, NeuralInference.
Follow-up
Each of SNPE A, B, C only override/define one method: _get_log_prob_proposal_posterior(self, inputs, context, masks); consider dealing with it in SnpeBase directly - unless we dispatch elsewhere on concrete class.
The text was updated successfully, but these errors were encountered:
alvorithm
changed the title
Repeated construction code in Inference classes - derive from common parent?
Repeated boilerplate across Inference classes: derive from common parent
Mar 23, 2020
Problem
Some of the argument checking across
SnpeBase
,SNL
andSRE
is repeated code.Solution
Refactor that commonality and others into a common parent class,
NeuralInference
.Follow-up
Each of SNPE A, B, C only override/define one method:
_get_log_prob_proposal_posterior(self, inputs, context, masks)
; consider dealing with it inSnpeBase
directly - unless we dispatch elsewhere on concrete class.The text was updated successfully, but these errors were encountered: