Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by Last Finished doesn't take custom dates into account #493

Closed
gardebreak opened this issue Apr 19, 2024 · 1 comment · Fixed by #494
Closed

Sort by Last Finished doesn't take custom dates into account #493

gardebreak opened this issue Apr 19, 2024 · 1 comment · Fixed by #494
Assignees
Labels
bug Hmm, this isn't working correctly
Milestone

Comments

@gardebreak
Copy link

Hey,

Thanks for adding the ability to sort by Last Finished. It doesn't seem to be taking custom "Finished" dates into account yet. I have a bunch of movies that I have added and backdated to the actual date that I watched them, by clicking on the activity log to bring up the "Edit Activity" dialogue and setting the actual watched date there. Finished dates set like this do not sort properly when sorting by "Last Finished."

@IRHM
Copy link
Member

IRHM commented Apr 20, 2024

Hey @gardebreak, thanks for reporting this, I just had a look and I only made it look at the updatedAt date on the activity, which doesn't help! Will fix this (by using the custom date you've set, and falling back to updatedAt if it isn't set).

@IRHM IRHM self-assigned this Apr 20, 2024
@IRHM IRHM closed this as completed in #494 Apr 20, 2024
@IRHM IRHM added this to the v1.39 milestone Apr 20, 2024
@IRHM IRHM added the bug Hmm, this isn't working correctly label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hmm, this isn't working correctly
Projects
Status: Tested
Development

Successfully merging a pull request may close this issue.

2 participants