Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode for Windows #1386

Closed
jeffsee55 opened this issue Apr 11, 2024 · 3 comments · Fixed by #1388
Closed

Support unicode for Windows #1386

jeffsee55 opened this issue Apr 11, 2024 · 3 comments · Fixed by #1388

Comments

@jeffsee55
Copy link
Contributor

Windows supports unicode characters but the figures library that determines this is outdated. I suspect this is intentional because later versions of figures only support ESM.

It would be nice if Windows users got unicode, though I'm not sure what the best path forward would be if dropping CJS support is not an option.

@SBoudrias
Copy link
Owner

I'm not against dropping figures and/or inlining core content of the library.

@jeffsee55
Copy link
Contributor Author

Great, I'm happy to take a stab at it. Would you prefer to inline it into it's own package within the monorepo or just put it into @inquirer/core?

@SBoudrias
Copy link
Owner

It's own package, like @inquirer/figures (basically a simple fork to support cjs), would be best.

If we didn't use figures in multiple packages, then I'd prefer to inline it in those packages. But that'd be a lot of noise today since it's used often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants