Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have runner run in a goroutine #2

Closed
sbrow opened this issue Jul 31, 2018 · 1 comment
Closed

Have runner run in a goroutine #2

sbrow opened this issue Jul 31, 2018 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@sbrow
Copy link
Owner

sbrow commented Jul 31, 2018

No description provided.

@sbrow sbrow added enhancement New feature or request wontfix This will not be worked on labels Jul 31, 2018
@sbrow
Copy link
Owner Author

sbrow commented Jul 31, 2018

The issue is that this requires some seriously major refactoring to take advantage of. The runner.Run function would need to be split into a queuing function (pushing the run call onto a channel), and a returning function, (pulling the call's result from the channel). Otherwise, the benefits are minimal.

@sbrow sbrow closed this as completed Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant