Make sure to create a jar with manifest

[raboof]

Fixes a regression introduced in
605d908

[eed3si9n]

[info] - it should create valid jar files *** FAILED ***
[info]   java.nio.file.NoSuchFileException: foo.txt
[info]   at com.sun.nio.zipfs.ZipFileSystem.newByteChannel(ZipFileSystem.java:636)
[info]   at com.sun.nio.zipfs.ZipPath.newByteChannel(ZipPath.java:739)
[info]   at com.sun.nio.zipfs.ZipFileSystemProvider.newByteChannel(ZipFileSystemProvider.java:255)
[info]   at java.nio.file.Files.newByteChannel(Files.java:361)
[info]   at java.nio.file.Files.newByteChannel(Files.java:407)
[info]   at java.nio.file.Files.readAllBytes(Files.java:3152)
[info]   at sbt.io.IOSpec.$anonfun$new$34(IOSpec.scala:236)
[info]   at sbt.io.IO$.withTemporaryDirectory(IO.scala:489)
[info]   at sbt.io.IO$.withTemporaryDirectory(IO.scala:499)
[info]   at sbt.io.IOSpec.$anonfun$new$33(IOSpec.scala:219)

[raboof]

Yes, apparently a jdk11-ism snuck into the test - I'll look into it later, but likely after christmas

…

On Tue, 24 Dec 2019, 18:50 eugene yokota, ***@***.***> wrote: [info] - it should create valid jar files *** FAILED *** [info] java.nio.file.NoSuchFileException: foo.txt [info] at com.sun.nio.zipfs.ZipFileSystem.newByteChannel(ZipFileSystem.java:636) [info] at com.sun.nio.zipfs.ZipPath.newByteChannel(ZipPath.java:739) [info] at com.sun.nio.zipfs.ZipFileSystemProvider.newByteChannel(ZipFileSystemProvider.java:255) [info] at java.nio.file.Files.newByteChannel(Files.java:361) [info] at java.nio.file.Files.newByteChannel(Files.java:407) [info] at java.nio.file.Files.readAllBytes(Files.java:3152) [info] at sbt.io.IOSpec.$anonfun$new$34(IOSpec.scala:236) [info] at sbt.io.IO$.withTemporaryDirectory(IO.scala:489) [info] at sbt.io.IO$.withTemporaryDirectory(IO.scala:499) [info] at sbt.io.IOSpec.$anonfun$new$33(IOSpec.scala:219) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#281?email_source=notifications&email_token=AABAGEFMMN2ZFCRUCBDIHR3Q2JDWPA5CNFSM4J67MEPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTPOLI#issuecomment-568784685>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABAGEASVEJGBZRVVMD26Y3Q2JDWPANCNFSM4J67MEPA> .

[raboof]

should be good to go now AFAICS - do you want me to squash or will you on merge?

[eed3si9n]

I can squash on merge.