New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EvictionWarningOptions.summary that tells the users to call "evicted" #211

Merged
merged 3 commits into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@exoego
Contributor

exoego commented Feb 15, 2018

Partially addresses sbt/sbt#3773

I followed the below note in the issue.

Next, we could add EvictionWarningOptions.summary that tells the users to call "evicted".

@typesafe-tools

This comment has been minimized.

typesafe-tools commented Feb 17, 2018

The validator has checked the following projects against Scala 2.12, 2.11, 2.10,
tested using sbt-allsources.sh.

Project Reference Commit
sbt 1.x sbt/sbt@78f7658
zinc 1.x sbt/zinc@3c12aba
io 1.x sbt/io@7f8c185
librarymanagement pull/211/head f8dbbd8
util 1.x sbt/util@9891f07
website 1.x sbt/website@5d5e3d5

The result is: SUCCESS
(restart)

@eed3si9n

LGTM
Sorry about the delayed review

@eed3si9n eed3si9n added this to the 1.2.0 milestone Mar 18, 2018

@dwijnand dwijnand merged commit 6feacbd into sbt:1.x Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Mar 19, 2018

@dwijnand

This comment has been minimized.

Member

dwijnand commented Mar 19, 2018

thanks @exoego!

eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment