Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EvictionWarningOptions.summary that tells the users to call "evicted" #211

Merged
merged 3 commits into from Mar 19, 2018
Merged

Add EvictionWarningOptions.summary that tells the users to call "evicted" #211

merged 3 commits into from Mar 19, 2018

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 15, 2018

Partially addresses sbt/sbt#3773

I followed the below note in the issue.

Next, we could add EvictionWarningOptions.summary that tells the users to call "evicted".

@eed3si9n eed3si9n added the ready label Feb 15, 2018
@exoego exoego mentioned this pull request Feb 15, 2018
Merged
@typesafe-tools
Copy link

The validator has checked the following projects against Scala 2.12, 2.11, 2.10,
tested using sbt-allsources.sh.

Project Reference Commit
sbt 1.x sbt/sbt@78f7658
zinc 1.x sbt/zinc@3c12aba
io 1.x sbt/io@7f8c185
librarymanagement pull/211/head f8dbbd8
util 1.x sbt/util@9891f07
website 1.x sbt/website@5d5e3d5

✅ The result is: SUCCESS
(restart)

eed3si9n
eed3si9n approved these changes Mar 18, 2018
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sorry about the delayed review

@eed3si9n eed3si9n added this to the 1.2.0 milestone Mar 18, 2018
@dwijnand dwijnand merged commit 6feacbd into sbt:1.x Mar 19, 2018
@dwijnand dwijnand removed the ready label Mar 19, 2018
@dwijnand
Copy link
Member

thanks @exoego!

@eed3si9n eed3si9n mentioned this pull request Jul 1, 2018
Merged
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Jul 1, 2018
@eed3si9n
LM 1.2.0-M3
c0030d5 
Fixes sbt#3773
Ref sbt/librarymanagement#211
Ref sbt/librarymanagement#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@exoego @typesafe-tools @dwijnand @eed3si9n