Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jar naming for cross-building #22

Closed
pr1001 opened this issue Nov 9, 2011 · 2 comments
Closed

Fix jar naming for cross-building #22

pr1001 opened this issue Nov 9, 2011 · 2 comments

Comments

@pr1001
Copy link

pr1001 commented Nov 9, 2011

Cross-builds seem to work but overwrite each previous language version built:

> +assembly
Setting version to 2.8.1
[info] Set current project to util (in build file:/Users/peter/Projects/Miogiro/Code/util/)
...
[info] Packaging /Users/peter/Projects/Miogiro/Code/util/target/util-assembly-0.1.jar ...
[info] Done packaging.
[success] Total time: 3 s, completed Nov 9, 2011 4:14:44 PM
Setting version to 2.9.1
[info] Set current project to util (in build file:/Users/peter/Projects/Miogiro/Code/util/)
... 
[info] Packaging /Users/peter/Projects/Miogiro/Code/util/target/util-assembly-0.1.jar ...
[info] Done packaging.
[success] Total time: 3 s, completed Nov 9, 2011 4:14:48 PM
Setting version to 2.9.1
[info] Set current project to util (in build file:/Users/peter/Projects/Miogiro/Code/util/)

The solution is to include the Scala version in the jar name. Basically, I would follow the sbt naming convention.

@eed3si9n
Copy link
Member

eed3si9n commented Nov 9, 2011

The idea behind assembly is to be independent of the Scala version. If you want to include Scala version name, you can override jarName in assembly.

@pr1001
Copy link
Author

pr1001 commented Nov 9, 2011

Sorry, it wasn't clear to me that it was supposed to be independent of Scala versions.

@pr1001 pr1001 closed this as completed Nov 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants