Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid git push output on stderr #116

Closed
wants to merge 1 commit into from
Closed

Conversation

bmontuelle
Copy link

Hello,

I was annoyed with git push output to stderr putting red error in release plugin output log. I see the log info message and issue #20 about it but I though it would be cleaner to avoid it completely.

I used git's push --porcelain switch to keep some useful info on the output (rev sha1 being pushed), but --quiet could have done it too.

Do you think this could be merged or is there another improvment we can add to this ?

Best regards,

@patrickliangli
Copy link

+1

Some build tools/systems check for [success] and [error] to determine if a build is successful or not, and having the git messages come out as [error] will fail the build even though everything is successful.

But doing quiet or porcelain seems to suppress real [error] messages.

@jroper
Copy link
Member

jroper commented Dec 15, 2015

Suppressing real error messages is a problem. The sbt process API allows passing a ProcessLogger, the default one that SBT uses forwards stderr to stderr, but you can implement one to forward stderr to stdout.

@jroper
Copy link
Member

jroper commented Feb 24, 2016

I've implemented this in #147, logging the git output at info.

@jroper jroper closed this Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants