-
Notifications
You must be signed in to change notification settings - Fork 935
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.2.x] on Scala 2.11 scala-parser-combinators 1.1.2 on test requires forking #4609
Comments
So basically sbt/zinc#505 fixed the bug for def makeLoader(classpath: Seq[File], instance: ScalaInstance): ClassLoader =
- filterByClasspath(classpath, makeLoader(classpath, instance.loader, instance))
+ filterByClasspath(classpath, makeLoader(classpath, instance.loaderLibraryOnly, instance)) but didn't for https://github.com/sbt/sbt/blob/v1.2.8/testing/src/main/scala/sbt/TestFramework.scala#L258 val dual = new DualLoader(
scalaInstance.loader, |
/cc @ashawley, since scala-xml is affected as well (on 2.11 and 2.12) |
@eatkins We still have this problem because ScalaInstance loader for Scala 2.11 probably is bringing in parser combinator - http://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.11.12/scala-compiler-2.11.12.pom |
Fixes sbt#4609 ScalaInstance contains unwanted Scala modules such as scala-xml and scala-parser-combinators.
Fixes sbt#4609 ScalaInstance contains unwanted Scala modules such as scala-xml and scala-parser-combinators.
allJars contains unwanted Scala modules. Having this in prevents the flat classloader from working correctly. Ref sbt#4609
* Support for Play 2.7.3 * Forking on Test for 2.11 build See sbt/sbt#4609
Reported originally by @Philippus as scala/scala-parser-combinators#197
steps
Philippus/bump#8
problem
Philippus/bump#8 fails with the following exception in scala 2.11:
expectation
No failure.
workarond
notes
This is a variation of
#3405
scala/scala-xml#195
sbt/zinc#505
The text was updated successfully, but these errors were encountered: