Remove conscriptConfigs task, not used and needed(?) anymore
#7353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
approved these changes
Aug 12, 2023
|
BTW, all the conscript launchconfigs have 1.3.0 set as version, shouldn't that be upgraded on each release: (Personally I don't care because I don't use that conscripts, just wanted to let you know) |
cwienberg
pushed a commit
to cwienberg/spark-sorting-helpers
that referenced
this pull request
Aug 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.3` -> `1.9.4` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.4`](https://togithub.com/sbt/sbt/releases/tag/v1.9.4): 1.9.4 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.3...v1.9.4) ##### CVE-2022-46751 [CVE-2022-46751](https://togithub.com/advisories/GHSA-2jc4-r94c-rp7h) is a security vulnerability discovered in Apache Ivy, but found also in Coursier. With coordination with Apache Foundation, Adrien Piquerez ([@​adpi2](https://togithub.com/adpi2)) from Scala Center backported the fix to both our Ivy 2.3 fork and Coursier. sbt 1.9.4 updates them to the fixed versions. #### Other updates - Fixes `sbt_script` lookup by replacing all spaces with `%20` (not only the first one) in the path. by [@​arturaz](https://togithub.com/arturaz) in [sbt/sbt#7349 - Fixes [scala-debug-adapter#543](https://togithub.com/scala-debug-adapter/sbt/issues/543): Maintain order of internal deps by [@​adpi2](https://togithub.com/adpi2) in [sbt/sbt#7347 - Removes `conscriptConfigs` task, not used and needed(?) anymore by [@​mkurz](https://togithub.com/mkurz) in [sbt/sbt#7353 - Adds a Scala 3 seed to the `sbt new` menu by [@​SethTisue](https://togithub.com/SethTisue) in [sbt/sbt#7354 #### new contributors - [@​arturaz](https://togithub.com/arturaz) made their first contribution in [sbt/sbt#7349 **Full Changelog**: sbt/sbt@v1.9.3...v1.9.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task was part of the release process, but is not used anymore since the release of sbt 1.5.1: 43b2f1e#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91L1525
Also, the conscript launchconfig files already diverged from the source
sbt.boot.propertiessince it does not contain thelocal-preloaded[-ivy]repos anymore: 181052f, but the conscript launchconfigs do: https://github.com/sbt/sbt/tree/1.9.x/src/main/conscriptIt seems those config were and get updated by hand anyway.
Since the task is not used in the release process anymore, I think it's more confusing to keep it (or @eed3si9n did run that task in the last years manually?).
(I stumpled over this because I was looking where/how the default repos are set up (which is https://github.com/sbt/sbt/blob/v1.9.3/launch/src/main/input_resources/sbt/sbt.boot.properties#L13-L19).