Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make classpath handling more uniform in AnalyzingCompiler #871

Closed
eed3si9n opened this issue Aug 10, 2020 · 0 comments · Fixed by #876
Closed

make classpath handling more uniform in AnalyzingCompiler #871

eed3si9n opened this issue Aug 10, 2020 · 0 comments · Fixed by #876

Comments

@eed3si9n
Copy link
Member

problem

Currently the classpath handling in AnalyzingCompiler differs from method to method.

expectation

We should pass classpath in as Seq[VirtualFile] even if we eventually convert them into absolute path String of NIO Path.

The latest compiler has support for PathFactory - scala/scala@71c91d5. This would likely allow virtualization of classpath in different ways, like in-memory JAR files and virtual directory.

eed3si9n added a commit to eed3si9n/zinc that referenced this issue Aug 10, 2020
Fixes sbt#871

This is a minor refactoring to add `classpath` parameter to `AnalyzingCompiler#compile(...)` like all other methods.
eed3si9n added a commit to eed3si9n/zinc that referenced this issue Aug 13, 2020
Fixes sbt#871

This is a minor refactoring to add `classpath` parameter to `AnalyzingCompiler#compile(...)` like all other methods.
eed3si9n added a commit to eed3si9n/zinc that referenced this issue Aug 14, 2020
Fixes sbt#871

This is a minor refactoring to add `classpath` parameter to `AnalyzingCompiler#compile(...)` like all other methods.
lrytz pushed a commit to lrytz/scala that referenced this issue Jul 13, 2023
Fixes sbt/zinc#871

This is a minor refactoring to add `classpath` parameter to `AnalyzingCompiler#compile(...)` like all other methods.

Rewritten from sbt/zinc@864444c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant