Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] sbt.internal.inc.Position: record range information #580

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

smarter
Copy link
Contributor

@smarter smarter commented Aug 22, 2018

This is a backport of #571 to the 1.2.x branch.

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@smarter smarter requested a review from eed3si9n August 22, 2018 14:09
@typesafe-tools
Copy link

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.2.x sbt/sbt@6eb3d9f
zinc pull/580/head a5a32a1
io 1.2.x sbt/io@fb0acb1
librarymanagement 1.2.x sbt/librarymanagement@f42ec6f
util 1.2.x sbt/util@05cecc3
website 1.2.x

❌ The result is: FAILED
(restart)

@smarter
Copy link
Contributor Author

smarter commented Aug 22, 2018

The validator failure looks like an external problem:

[error] java.lang.RuntimeException: 
[error] 
[error] Fatal: multiple projects have the same artifacts visible in the same space.
[error] 
[error]   org.scala-sbt#zinc-classpath  from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error]   org.scala-sbt#zinc-apiinfo  from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error]   org.scala-sbt#zinc-classfile  from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error]   org.scala-sbt#compiler-bridge  from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error] 
[error] 	at scala.sys.package$.error(package.scala:27)
[error] 	at com.typesafe.dbuild.model.RepeatableDBuildConfig.<init>(RepeatableBuild.scala:158)
[error] 	at com.typesafe.dbuild.model.RepeatableDBuildConfigH$.fromExtractionOutcome(RepeatableBuild.scala:71)
Shutting down, please wait...
Result: EXTRACTION FAILED (Cause: RuntimeException: )
Build failed after: 00h 02m 47.1s
All done.
/tmp/jenkins1188539459569619282.sh: line 305: jq: command not found

Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I leave this up to Eugene or Dale to merge.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eed3si9n eed3si9n merged commit a022a4f into sbt:1.2.x Aug 22, 2018
smarter added a commit to smarter/zinc that referenced this pull request Aug 28, 2018
This was forgotten in sbt#580. We need to define asProduct13 ourselves
since it's missing from sbinary, see
sbt/sbinary#17
smarter added a commit to smarter/zinc that referenced this pull request Aug 30, 2018
This was forgotten in sbt#580. Also bump sbinary to 0.5.0 to make
`asProduct13` from sbt/sbinary#17 available.
smarter added a commit that referenced this pull request Aug 30, 2018
Follow-up to the fields added in #580, and add Problem#rendered
jvican pushed a commit to scalacenter/zinc that referenced this pull request Dec 15, 2019
This was forgotten in sbt#580. Also bump sbinary to 0.5.0 to make
`asProduct13` from sbt/sbinary#17 available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants