Add methods asProduct10 to asProduct21 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sbt/util#173, Position now has 13 fields so TextAnalysisFormat in Zinc needs asProduct13. While we're at it we bump the max to 21 to give us some legroom.
|
@eed3si9n Mima fails because adding a method to a trait in 2.10 and 2.11 isn't binary-compatible (in 2.12 it's okay), should I bump the major version, drop 2.10/2.11 or filter the failure? |
smarter
added a commit
to smarter/zinc
that referenced
this pull request
Aug 28, 2018
This was forgotten in sbt#580. We need to define asProduct13 ourselves since it's missing from sbinary, see sbt/sbinary#17
|
Since Zinc is the only intended customer it doesn't really matter what we do here, but I think bumping to 0.5.0 is the best of these options. |
eed3si9n
requested changes
Aug 29, 2018
This is necessary since the previous commit broke BC on 2.10/2.11
|
Done. |
eed3si9n
approved these changes
Aug 29, 2018
smarter
added a commit
to smarter/zinc
that referenced
this pull request
Aug 30, 2018
This was forgotten in sbt#580. Also bump sbinary to 0.5.0 to make `asProduct13` from sbt/sbinary#17 available.
jvican
pushed a commit
to scalacenter/zinc
that referenced
this pull request
Dec 15, 2019
This was forgotten in sbt#580. Also bump sbinary to 0.5.0 to make `asProduct13` from sbt/sbinary#17 available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sbt/util#173, Position now has 13 fields
so TextAnalysisFormat in Zinc needs asProduct13. While we're at it we
bump the max to 21 to give us some legroom.