Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one room available when configuring room colors (reopened) #180

Closed
2 tasks done
sca075 opened this issue Jun 8, 2024 Discussed in #179 · 4 comments · Fixed by #196
Closed
2 tasks done

Only one room available when configuring room colors (reopened) #180

sca075 opened this issue Jun 8, 2024 Discussed in #179 · 4 comments · Fixed by #196
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@sca075
Copy link
Owner

sca075 commented Jun 8, 2024

Discussed in #179

Originally posted by kevinduong May 29, 2024

Checklist

  • I have updated the integration to the latest version available
  • I have checked if the problem is already reported

The problem

When changing room colors, only one option shows up for one room. The integration is reporting multiple segements (7). When adjusting this color, it didn't modify the floor color which I would have expected if there was an issue with segments/rooms. It correctly updated the color of the one room.

image

image

What version of an integration has described problem?

2024.6.0

What was the last working version of an integration?

No response

What vacuum model do you have problems with?

Roborock S5 Valetudo

Please firmware installed on your Vacuum.

2024.02.0

What type of platform you use?

VEMLinux (Virtual Machine) such as Proxmox, VMWare, etc.

What version of Home Assistant do you use?

core-2024.5.5

What type of installation are you running?

Home Assistant OS

Camera's settings.

No response

Logs or Errors shown in the HA snapshots (please enable the Debug Mode)

No response

Additional information

No response

@sca075 sca075 added bug Something isn't working help wanted Extra attention is needed labels Jun 8, 2024
@sca075 sca075 self-assigned this Jun 8, 2024
@sca075 sca075 added this to the 2024.07.0 milestone Jun 9, 2024
@sca075
Copy link
Owner Author

sca075 commented Jun 9, 2024

Although currently is implemented a work around for this issue, will investigate more in deep on it as per the room count for vacuums such as V1 should be 1 not 16 (that is the complete range of possible colours for the segments).
This issue therefore remain open for tracking purposes, and do not effect the component performances.

@sca075
Copy link
Owner Author

sca075 commented Jun 28, 2024

@kevinduong in the recent released I was probably able to fix this is issue. The Default number of room was reduce again to 1, the 2024.07.0 will be soon released and It would be really great when you confirm that you can still edit the rooms colours. If not I will try to close this within this milestone.

@sca075
Copy link
Owner Author

sca075 commented Jun 30, 2024

@kevinduong just to make it sure I will do the following test.

  • Remove the camera completely from HA (including the files in .storage).
  • Setup the entity again and check that all required files are available for counting the rooms.
    This should ensure that the issue can be reproduced. So do not worry about the above request please.

@sca075
Copy link
Owner Author

sca075 commented Jun 30, 2024

Did re-test it and all works fine so will close this issue with next release.

@sca075 sca075 linked a pull request Jun 30, 2024 that will close this issue
@sca075 sca075 closed this as completed in ad3d2e4 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant