Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from ethers to viem (and wagmi 1.*) #229

Closed
rin-st opened this issue Mar 9, 2023 · 7 comments · Fixed by #352
Closed

Migration from ethers to viem (and wagmi 1.*) #229

rin-st opened this issue Mar 9, 2023 · 7 comments · Fixed by #352
Assignees
Labels
discussion Further information is discussed waiting Can't start working on the issue (it has dependencies)

Comments

@rin-st
Copy link
Member

rin-st commented Mar 9, 2023

What do you think about migrating to Viem, a new alternative to ethers.js and web3.js from the creators of wagmi?

Why Viem

@rin-st rin-st added the discussion Further information is discussed label Mar 9, 2023
@sverps
Copy link
Collaborator

sverps commented Mar 9, 2023

It's unclear how mature Viem already is. In the wagmi project, I see they still use ethers (so even they haven't switched over yet to their own library). So it looks like a cool new lib, and their goal sounds really nice, but I'm unsure if it is stable enough to already switch over to it.

@carletex
Copy link
Member

carletex commented Mar 9, 2023

Thanks for bringing this Rinat! Just saw it the other day, and it's in my list to download and test it.

It's unclear how mature Viem already is. In the wagmi project, I see they still use ethers (so even they haven't switched over yet to their own library). So it looks like a cool new lib, and their goal sounds really nice, but I'm unsure if it is stable enough to already switch over to it.

+1

I've seen before how trying to use the shiny new libraries can ruin the stability of the project. As a rule, I'd never use a library that is so new, specially when the existing lib does the job well and the "only" benefit is "performance / bundle size "....where we don't really have a problem. The only thing that I don't like about ethers, is their DOCS haha

In any case, we should definitely use it outside of SE-2, get a feel of it, and when wagmi intregrates it (in their v1.0 I think) we can reconsider.

@rin-st
Copy link
Member Author

rin-st commented Mar 9, 2023

I've seen before how trying to use the shiny new libraries can ruin the stability of the project.

I'm too conservative to do that too most of the time, don't even remember when I did that. But for some reason, I decided to give Viem a try. Agree with you guys, let's test it outside of SE-2 and wait for integration to wagmi (yes, it will be 1.0)

@rin-st rin-st added the waiting Can't start working on the issue (it has dependencies) label Mar 9, 2023
@technophile-04
Copy link
Collaborator

Love the discussion, been thinking about it 🙌

In any case, we should definitely use it outside of SE-2, get a feel of it, and when wagmi intregrates it (in their v1.0 I think) we can reconsider.

+++

@carletex
Copy link
Member

Closing this for now.... but let see how we feel about it in a few months or when wagmi v1.0 is out ;)

@jxom
Copy link

jxom commented May 21, 2023

How do you feel about it now? 😀

@carletex
Copy link
Member

@jxom Good enough to re-open the issue :)

@carletex carletex reopened this May 22, 2023
@carletex carletex changed the title Migration from ethers to viem Migration from ethers to viem (and wagmi 1.*) May 22, 2023
@technophile-04 technophile-04 self-assigned this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Further information is discussed waiting Can't start working on the issue (it has dependencies)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants