Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor meta tags into separate react component and add new tags #359

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Refactor meta tags into separate react component and add new tags #359

merged 6 commits into from
Jun 1, 2023

Commits on May 31, 2023

  1. Create MetaHeader component and use it on index 

    Also add favicon and thumbnail files
    @Pabl0cks
    Pabl0cks committed May 31, 2023
    Configuration menu
    Copy the full SHA
    ea7dcd2 View commit details
    Browse the repository at this point in the history

  2. Tweaks to solve PR comments fom carletex

    @Pabl0cks
    Pabl0cks committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0283763 View commit details
    Browse the repository at this point in the history

  3. Simplify number of image props

    @Pabl0cks
    Pabl0cks committed May 31, 2023
    Configuration menu
    Copy the full SHA
    efe2e35 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Adjust comments from PR 359 

    - Change interface for type in MetaHeader
- Add children logic to MetaHeader
- Send font <links as children to MetaHeader in example-ui.tsx
- Adjust title and descriptions of Debug and Example UI pages
- Remove comments that don't give extra context to the code
- Group title, descriptions and image in  MetaHeader return.
    @Pabl0cks
    Pabl0cks committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    de943f7 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts

    @carletex
    carletex committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    c675110 View commit details
    Browse the repository at this point in the history

  3. Copys nitpicks

    @carletex
    carletex committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    fd56dac View commit details
    Browse the repository at this point in the history