Refactor meta tags into separate react component and add new tags #359

Pabl0cks · 2023-05-31T10:43:20Z

Description

Create MetaHeader component and use it on index, add favicon and thumbnail files to repo.

Additional Information

I have read the contributing docs (if this is your first contribution)
This is not a duplicate of any existing pull request

Related Issues

This PR resolves #358

_Closes #358 _

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address: pabl0cks.eth

Also add favicon and thumbnail files

packages/nextjs/components/MetaHeader.tsx

packages/nextjs/pages/index.tsx

packages/nextjs/components/MetaHeader.tsx

carletex

Thanks for this @Pabl0cks

Left some review comments. Let me know if you have any questions.

Pabl0cks · 2023-05-31T22:55:07Z

I think all the comments are fixed in the couple of commits I've just pushed @carletex

Had a couple of doubts:

example-ui.tsx had a couple of elements to import fonts, which we are not migrating to MetaHeader. Is it correct to leave it like that?

      <MetaHeader
        title="Scaffold-ETH 2 Example UI"
        description="This is just an Example UI created with 🏗 Scaffold-ETH 2, showcasing some of its features."
      />
      <Head>
        {/* We are importing the font this way to lighten the size of SE2. */}
        <link rel="preconnect" href="https://fonts.googleapis.com" />
        <link href="https://fonts.googleapis.com/css2?family=Bai+Jamjuree&display=swap" rel="stylesheet" />
      </Head>

The other doubt was if keep 2 different props for ogImage and twitterImage, because of the absolute path thing for Twitter, but I think I've managed to simplify it in the last commit

Pabl0cks · 2023-06-01T13:30:14Z

Revised with Carlos, will do a few more tweaks after his suggestions.

- Change interface for type in MetaHeader - Add children logic to MetaHeader - Send font <links as children to MetaHeader in example-ui.tsx - Adjust title and descriptions of Debug and Example UI pages - Remove comments that don't give extra context to the code - Group title, descriptions and image in MetaHeader return.

carletex

Great job @Pabl0cks !!

* Update SE-2 nomenclautre (#317) * Fix autoConnect when contract not deployed (#292) * oxford comma lol * Fix icon visibility on dark mode in EtherInput (#320) * Update README: Add Vercel ENV var to disable type/lint checking (#327) * Fix typo (#334) Fix typo at code snippet * README: Updated SE-2 custom hook section (#330) Co-authored-by: KcPele <fidekg123@gmail.com> Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Remove duplicated HINT on README (#335) * PR and Issue templates (#329) * Native currency symbol and price as per target network (#322) * useAppStore => useGlobalState (#338) * Event history filter type (#333) * fix: event history filter type Fixes #332 * fix: make scaffold event history config separate type * fix: prettier broke due to invalid syntax * fix: ts error after generating contract * Indexed prop + example --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Update README: custom hooks section (#339) * fix: assert type as Abi to avoid ts error (#350) * fix: assert type as Abi to avoid ts error Fixes #344 * assert type as Abi to avoid ts error on useScaffoldContract --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Fix useEffect filter dep on event hook (#349) * Block confirmation options / callback for useScaffoldContractWrite (#348) * Patch useLocalStorage setting the right initial value to avoid a hydration error (#356) Co-authored-by: sverps <sverps@gmail.com> * Save selected contract to local storage (#326) * Save selected contract to local storage * refactor: Replaced native localStorage with useLocalStorage from usehooks-ts * Fixed empty string parameter error. * Updated parameter requirements to fix issue. * Fixed error. * Fixed parameter assignment error. * Use useLocalStorage to save selected contract --------- Co-authored-by: Damian <damianmarti@gmail.com> * Refactor meta tags into separate component and add default thumbnail / image (#359) * Hotfix: thumbnail.png => thumbnail.jpg * Local Block Explorer (#351) Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com> * Fix daisyUI dropdown on IOS (#342) * allow `overrides` in useScaffoldContractWrite (#345) * allow overrides for useScaffoldContractWrite * spread overrides and restConfig separately * feat: proactively disable read hook when it would result in error (#250) Fixes #249 Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> * Size prop on Address component (#365) Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Generate TS ABIs from deploy script (#368) * enable solidity optimizer by default (#360) * fix(Balance): font-size of symbol should be relative to current font-size, not document root (#375) * fix(contract.ts): very long abi's now no longer go over type instantiation limit (#377) Fixes #374 * fix(contract.ts): improve missing config check (#372) Fixes #371 * fix listner types error when contracts missing (#379) * zkSyncEra Testnet config (#383) * Upgrade hardhat-deploy to 0.11.26 where zkSync is supported * Dependency for @matterlabs/hardhat-zksync-solc * Add zkSyncEraTestnet to networks * Import @matterlabs/hardhat-zksync-solc * Add artifacts-zk and cache-zk to gitignore * yarn install * Add zkSync mainnet config * add hardhat-zksync-verify for contract verification --------- Co-authored-by: moltam89 <moltam89@gmail.com> Co-authored-by: Damian <damianmarti@gmail.com> Co-authored-by: Shiv Bhonde <shivbhonde04@gmail.com> * allow writeAsync by useScaffoldContractWrite to be called with updated args (#385) * update wagmi & rainbow for walletConnectV2 (#381) * meged changes from main, additional configuration in subgraph.yaml --------- Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Austin Griffith <austin@ethereum.org> Co-authored-by: Kevin Joshi <kevinjoshi46b@gmail.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: AlehN <natsevsky@gmail.com> Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com> Co-authored-by: KcPele <fidekg123@gmail.com> Co-authored-by: Samuel | solidixen.eth <sverps@gmail.com> Co-authored-by: Eda Akturk <edakturk96@gmail.com> Co-authored-by: Tamas Molnar <tamas.molnar@liferay.com> Co-authored-by: Damian Martinelli <damianmarti@gmail.com> Co-authored-by: Alexander <a00112699@gmail.com> Co-authored-by: port <108868128+portdeveloper@users.noreply.github.com> Co-authored-by: moltam89 <moltam89@gmail.com>

Create MetaHeader component and use it on index

ea7dcd2

Also add favicon and thumbnail files

Pabl0cks mentioned this pull request May 31, 2023

Refactor meta tags into separate react component and add new tags #358

Closed

2 tasks

carletex self-requested a review May 31, 2023 10:52

sverps approved these changes May 31, 2023

View reviewed changes