Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JDK version parsing for EA builds #153

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

SlowBrainDude
Copy link

This would fix an issues I've run into surfacing like:

me@m1:~/projects/bleep$ bleep compile
📗 bootstrapped in 10 ms
📙 Your build uses the default system JVM, which can change outside the build. For stable builds over time, let bleep manage your chosen JVM by adding it to bleep.yaml
📗 bloop-rifle: Starting compilation server
📕 command failed unexpectedly java.lang.RuntimeException: Fatal error, could not spawn Bloop: failed to parse output: 'bloop v1.5.6-sc-4

Using Scala v2.12.17 and Zinc v1.8.0
Running on Java JDK v17.0.9-ea (/usr/lib/jvm/java-17-openjdk-amd64)
  -> Supports debugging user code, Java Debug Interface (JDI) is available.
Maintained by the Scala Center and the community.
'
        at scala.build.bloop.BloopServer$.ensureBloopRunning$$anonfun$2(BloopServer.scala:114)
        at scala.util.Either.fold(Either.scala:190)
        at scala.build.bloop.BloopServer$.ensureBloopRunning(BloopServer.scala:114)
        at scala.build.bloop.BloopServer$.bsp(BloopServer.scala:154)
        at scala.build.bloop.BloopServer$.buildServer(BloopServer.scala:184)
        at bleep.BleepCommandRemote.run(BleepCommandRemote.scala:49)
        at bleep.Main$.$anonfun$41$$anonfun$1$$anonfun$2(Main.scala:482)
        at bleep.Main$.run$$anonfun$1(Main.scala:546)
        at scala.util.Try$.apply(Try.scala:210)
        at bleep.Main$.run(Main.scala:546)
        at bleep.Main$.$anonfun$41$$anonfun$1(Main.scala:482)
        at bleep.logging.TypedLoggerResource$.bleep$logging$TypedLoggerResource$Ops$$anon$4$$_$use$$anonfun$4(TypedLoggerResource.scala:41)
        at bleep.logging.TypedLoggerResource$Ops$$anon$1.use$$anonfun$1(TypedLoggerResource.scala:20)
        at bleep.logging.TypedLoggerResource$.bleep$logging$TypedLoggerResource$Ops$$anon$3$$_$use$$anonfun$3$$anonfun$1(TypedLoggerResource.scala:34)
        at bleep.logging.TypedLoggerResource$$anon$6.use(TypedLoggerResource.scala:56)
        at bleep.logging.TypedLoggerResource$Ops$$anon$3.use$$anonfun$3(TypedLoggerResource.scala:34)
        at bleep.logging.TypedLoggerResource$Ops$$anon$1.use$$anonfun$1(TypedLoggerResource.scala:20)
        at bleep.logging.TypedLoggerResource$$anon$7.use(TypedLoggerResource.scala:67)
        at bleep.logging.TypedLoggerResource$Ops$$anon$1.use(TypedLoggerResource.scala:20)
        at bleep.logging.TypedLoggerResource$Ops$$anon$3.use(TypedLoggerResource.scala:36)
        at bleep.logging.TypedLoggerResource$Ops$$anon$1.use(TypedLoggerResource.scala:20)
        at bleep.logging.TypedLoggerResource$Ops$$anon$4.use(TypedLoggerResource.scala:41)
        at bleep.Main$.$anonfun$41(Main.scala:484)
        at bleep.ExitCode.andThen(ExitCode.scala:6)
        at bleep.Main$.main(Main.scala:486)
        at bleep.Main.main(Main.scala)

Could this be released as something like io.github.alexarchambault.bleep::bloop-rifle:1.5.10-sc-2?

I have also prepared a patch for bleep incorporating this changed dep. I'm going to create a PR there as a next step.

Copy link
Collaborator

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit ef4ea5a into scala-cli:main Sep 22, 2023
13 checks passed
@SlowBrainDude
Copy link
Author

Thank you for taking care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants