Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bsp4j to 2.1.0-M6 #154

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Update bsp4j to 2.1.0-M6 #154

merged 1 commit into from
Sep 22, 2023

Conversation

lwronski
Copy link
Collaborator

@lwronski lwronski commented Sep 21, 2023

I removed line with:

buildClient.onConnectWithServer(server)

because it was removed from BSP and it wasn't a proper json-rpc notification. build-server-protocol/build-server-protocol#555

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit ebe09e1 into scala-cli:main Sep 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants