New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last updated to each page beneath title based on git commit #3520
Conversation
I'm wondering how readthedocs will build the doc, |
Now that you removed the "continue to next page", is that generated for you? |
I wanted to rework the docs before but just haven't found time. See #2529 I really think a |
yes 👍 I'm not sure how |
I actually did something similar a while back :D I think I just used pandoc. |
Scaladoc 3 can do static sites and the project scaladoc can be integrated. I think the results is very nice and there is a chance if we support the project, it could improve. |
The documentation built by Docusaurus looks great, and the migration seems easy. We would just need to convert the documentation to Markdown, configure a few plugins and scripts, deploy it to GitHub Pages, and change the scala-native.org domain to point to the new page. I'm not sure who manages the domain, but once we find out, that should be easy to do. By the way, the most important change in this pull request is not the theme change to Furo, but the addition of the last modified date of the documentation to the head of the documentation. Those options seem very attractive, but what do you think about discussing which of the two changes (introduction of Furo and display of last-modified date) to include or not in this pull request for the time being? We can also discuss the long-term documentation plan in #2529. |
@tanishiking Since you asked...
|
Thanks @LeeTibbert
Yeah, that seems better to move on, I'll make this PR to focus on the "last updated" thing, and make another PR for theme stuffs.
There is in the PR description #3520 (comment) and we have it on the top of the page (beneath the page title).
Gotcha, I'll build with at least 3 alternatives and upload the HTML files + screenshot in another PR 👍 It may take some time since I might be away from computer until next Tuesday |
At least I updated this PR to remove theme related change + updated the description :) |
It seems it's not reflected on https://scala-native.org/en/latest/ even though we have |
The scala-native.org should be correclty showing the new version of scaladoc. Now the latest version points to version build from main branch. However, still the default version is stable which points to 0.4.14 (0.4.15 failed to build due to missing .readthedocs.yml, can't fix it) |
Oh, right. Indeed https://scala-native.org/en/latest/ have the ones 👍 |
You are invited to the parade the local town square in celebration & thanksgiving for this one, I think a welcome byproduct of the original Issue is that the 0.5.0-SNAPSHOT is now getting |
…a-native#3520) * Cosmetic website / add last updated to each page based on git log * Remove unnecessary link to the next page * Update readthedocs.yml (cherry picked from commit 81b25a9)
* Cosmetic website / add last updated to each page based on git log * Remove unnecessary link to the next page * Update readthedocs.yml (cherry picked from commit 81b25a9)
fix #3519
(Previously this PR is twofold: changing theme to furo + Add "Last Updated", but after some conversations we decided to focus on the latter one for the time being)
If introducing a different theme (furo) is controversial, I can split a PR into two (Add "Last updated" beneath the page title + furo theme)Add "Last updated" beneath the page title to each page
Using mgeier/sphinx-last-updated-by-git: ⌚ Get the "last updated" time for each Sphinx page from Git and a little bit of JavaScript, each page has a
Last Updated
based on the git commit history beneath the page title.The built HTML is available last-updated.zip
this will fix part of #3392
Old description
Introduces Furo sphinx theme
We'd been using the default sphinx theme sphinx-doc/alabaster which is mature good old sphinx theme. (I feel like it's old vive has a good fit with scala-native's logo brand 😄 ), but unfortunately there's a few issues with it
The good alternatives I know of are pradyunsg/furo, readthedocs/sphinx_rtd_theme, and pydata/pydata-sphinx-theme (They're the most starred sphinx theme on github https://github.com/topics/sphinx-theme). All of them looks better than Alabaster, but I'd like to recommend
furo
becausesphinx_rtd_theme
doesn't have dark themepydata-sphinx-theme
gives quite a lot of customizability to us User Guide — PyData Theme documentation, which seems too much for usfuro
solves the all the issues I have + it provides simple but enough customizability + I like it's minimal designgalleries
Screen.Recording.2023-10-02.at.10.48.47.mov
Test by yourself
./scripts/makedocs setup
./scripts/makedocs