Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for scala.reflect.api #11709

Closed
ashawley opened this issue Aug 25, 2019 · 5 comments · Fixed by scala/scala#8796
Closed

Update docs for scala.reflect.api #11709

ashawley opened this issue Aug 25, 2019 · 5 comments · Fixed by scala/scala#8796

Comments

@ashawley
Copy link
Member

ashawley commented Aug 25, 2019

After scala/scala#7587 removed a bunch of deprecated stuff for 2.13, a lot of the api docs need to be updated.

For instance, the code example at https://github.com/scala/scala/blob/v2.13.0/src/reflect/scala/reflect/api/Constants.scala#L137-L187

There may be others.

@l-cdc
Copy link

l-cdc commented Mar 7, 2020

I will look into this.

@l-cdc
Copy link

l-cdc commented Mar 21, 2020

@ashawley Please review. Should I also create a PR to fix this example in docs?

@ashawley
Copy link
Member Author

ashawley commented Mar 22, 2020

Someone else more qualified should review the changes to the reflection API in scala/scala#8796 . Hopefully, someone steps forward.

PS. Thanks for catching the bad reference I made to the PR. I fixed it in the description above.

@l-cdc
Copy link

l-cdc commented May 18, 2020

@SethTisue Please review, thanks!

@SethTisue
Copy link
Member

I've merged @lorenzocc's PR, which auto-closed this ticket.

However this ticket is pretty open-ended — it's the kind of ticket that if we leave it open, is liable to remain open forever because no one is going to be sure whether something was missed or not.

It's arguable, but I suggest we leave it closed. In general, there are many inadequacies in our documentation and we don't keep individual open tickets for them, though we're very happy to accept pull requests that address them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants