-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to spray 1.3.2 #68
Conversation
May fix first part of #67 |
Can you trigger a build for this one? |
If it works we can try running the tests as well. |
ca9ec33
to
2d5bc84
Compare
This failed but it showed a few interesting things:
I made a small update to the spray build and updated this PR to use the new version. Could you trigger another build with this version? |
Running here: https://jenkins-dbuild.typesafe.com:8499/job/Community-2.11.x-manual/76/console I found this comment related to shapeless in the config:
I'm wondering if this might cause problems for you trying to upgrade to stable version of spray? |
@@ -59,7 +59,8 @@ vars: { | |||
// TODO: merge required changes upstream to get rid of our forks, maintaining our one won't scale | |||
browse-ref : "retronym/browse.git#topic/2.11-compat" | |||
lift-framework-ref : "lift/framework.git#3.0-M2-release" | |||
spray-ref : "gkossakowski/spray.git#1.3-scala-2.11" | |||
// basically spray 1.3.2 with some build fixes applied | |||
spray-ref : "spray/spray.git#43d93b255c6a7f9e510111e9272d83e228638304" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those build fixes be included in future versions of spray so we can stick to a tag?
Given that this builds successfully I'm going to merge it because it's net improvement. We can look into shapeless situation as a second step. |
Thanks for contribution! |
Yes, right, I read this but forgot about it later on. I think this is just an old comment and we should try to update to a proper tag of shapeless.
Yes, exactly, it's current HEAD of the regular |
This disables legacy subprojects depending on shapeless 1.