Update migration guide #2015
Merged
Update migration guide #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, the tests fail because a link is broken: |
adpi2
force-pushed
the
update-migration-guide
branch
2 times, most recently
from
8f6a001
to
501709e
Compare
neko-kai
reviewed
May 13, 2021
neko-kai
reviewed
May 13, 2021
|
@b-studios in case this is ready, I put a link to it into the 2.13.6 release notes :) |
|
@b-studios I think it's acceptable to merge and remove the fence in a post-merge commit. It's unlikely there's an intention behind it, since it's missing in the original migration guide repository, so I see no reason to fret over it too much if there's a hurry for release notes inclusion... |
adpi2
force-pushed
the
update-migration-guide
branch
from
501709e
to
ab894b9
Compare
adpi2
force-pushed
the
update-migration-guide
branch
from
ab894b9
to
88e7780
Compare
|
Should be ready to merge now. |
|
Thanks @adpi2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix more links
Port latest changes:
-no-indentinstead of-noindentscalacenter/scala-3-migration-guide#204 by @unkarjedy