Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for scala.js 0.6.x #96

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Jun 29, 2020

and update scala.js 1.0.1 to 1.1.0

@Philippus Philippus requested a review from SethTisue June 29, 2020 09:01
@Philippus Philippus changed the title Drop support for scalajs 0.6.x Drop support for scala.js 0.6.x Jun 29, 2020
@exoego
Copy link

exoego commented Jun 29, 2020

I am agraid that upgrading Scala.js to 1.1.x causes org.scalajs.ir.IRVersionNotSupportedException in projects where Scala.js 1.0.x are used.
(Maybe I am wrong ?)
Ref. scalatest/scalatest#1830

@SethTisue
Copy link
Member

SethTisue commented Jul 1, 2020

@exoego yes, if we move to 1.1 here, then downstream users must move to 1.1 as well

I also discussed this with Seb at https://users.scala-lang.org/t/announcing-scala-js-1-1-0/6053 . I was cautious enough to want to ask, as were you on the ticket you linked to, but my conclusion is: if Seb isn't worried, I'm not worried either.

we see this as well in the sbt ecosystem, where theoretically everybody ought to be building their sbt plugins on sbt 1.0.0 still, but in practice they don't and that's been okay. sometimes you have to upgrade your sbt when you upgrade a plugin

@exoego
Copy link

exoego commented Jul 1, 2020

OK, I understood scalatest/scalatest#1830 (comment) by sjrd, and am not worrying about 1.x compatibility issue any more.

@SethTisue SethTisue merged commit b150bf8 into scala:master Jul 1, 2020
@Philippus Philippus deleted the drop-support-for-scalajs-0.6.x branch August 1, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants