Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around scala/bug#11125 #122

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Sep 20, 2018

this incurs a deprecation warning on 2.12.6, but we don't have
fatal warnings enabled in this repo. the deprecation warnings
will go away once we start building on 2.12.7.

references scala/bug#11125

this incurs a deprecation warning on 2.12.6, but we don't have
fatal warnings enabled in this repo. the deprecation warnings
will go away once we start building on 2.12.7.
@SethTisue SethTisue merged commit b52227d into scala:master Sep 21, 2018
@SethTisue SethTisue deleted the fix-string-lines branch September 21, 2018 00:03
@SethTisue
Copy link
Member Author

this is so we can build on JDK 11 in the Scala community build

@SethTisue
Copy link
Member Author

merged onto 2.13.x branch in 1bcf341

@SethTisue
Copy link
Member Author

gah, .linesIterator doesn't exist anymore in 2.13.0-M5. so for 2.13.x I did 994154f instead, using Predef.augmentString(...).lines

@SethTisue SethTisue changed the title use .linesIterator to work around scala/bug#11125 work around scala/bug#11125 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant