Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #58 (SI-4528) BasicTransformer has no longer exponential complexity #59

Merged
merged 3 commits into from
Jul 29, 2015
Merged

Fix #58 (SI-4528) BasicTransformer has no longer exponential complexity #59

merged 3 commits into from
Jul 29, 2015

Conversation

biswanaths
Copy link
Member

Replaced the transform(ns) // tranform sequence with one of the proposed methodhttps://issues.scala-lang.org/browse/SI-4528

Added tests to verify that the transform is reusing all the nodes it should be, also equivalency of the original, modified and the alternate option.

Please let me know, if there are any issue with the pull request.

@adriaanm
Copy link
Contributor

adriaanm commented Jul 8, 2015

LGTM -- would be good to fix typos in commit message, include the longer description from the PR, and mention the github issue as "Fixes #58", which will cause github to cross-link.

I suggest a title like "Fix #58 (SI-4528) BasicTransformer no longer exponential"

@adriaanm
Copy link
Contributor

adriaanm commented Jul 8, 2015

Thanks, @biswanaths! I'll add you to the scala-xml admins so you can merge go through the other PRs and merge those that are ready.

@biswanaths biswanaths changed the title Removing exponential complexity, Issue-58 Fixes #58 : removing exponential complexity from the xml transformer Jul 15, 2015
@biswanaths biswanaths changed the title Fixes #58 : removing exponential complexity from the xml transformer Fixes #58 : Basic transformer has no longer exponential complexity Jul 15, 2015
@biswanaths biswanaths changed the title Fixes #58 : Basic transformer has no longer exponential complexity Fix #58 (SI-4528) BasicTransformer has no longer exponential complexity Jul 15, 2015
@biswanaths
Copy link
Member Author

@adriaanm , updated the commit message to follow the standards as suggested by you.

@adriaanm
Copy link
Contributor

Thanks! I'll let you do the honors :)

biswanaths added a commit that referenced this pull request Jul 29, 2015
Fix #58 (SI-4528) BasicTransformer has no longer exponential complexity
@biswanaths biswanaths merged commit 4b1998a into scala:master Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants