Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor more deprecations under separate compilation #10291

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 4, 2023

Honor more deprecations under separate compilation.

Fixes scala/bug#12714

Restore that the symbol gets deprecation directly in classfile parser.

Partest files without a group are in group -1, not group 0 or a last group. (I assumed last round.)

The loose partitioning between jvm tests and run is unfortunate.

I could not decipher the change that is reverted here. That change is also seen in the jvm test.

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Feb 6, 2023
@som-snytt som-snytt force-pushed the issue/12714-kotlin-deprecation branch from 03a46ad to 4d5849a Compare February 10, 2023 20:01
@som-snytt som-snytt marked this pull request as ready for review February 11, 2023 07:55
@SethTisue
Copy link
Member

This is looking mergeable... Could you attempt to provide a good user-facing PR title and description?

@som-snytt som-snytt changed the title Restore symbol gets deprecation directly Honor more deprecations under separate compilation Feb 17, 2023
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps @lrytz would like to eyeball the implementation

@SethTisue SethTisue added the prio:hi high priority (used only by core team, only near release time) label Feb 20, 2023
@SethTisue SethTisue requested a review from lrytz February 21, 2023 04:35
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants