Fix SI-6584, Stream#distinct uses too much memory. #1535
Conversation
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/788/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1498/ |
|
jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1498/ |
|
jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/788/ |
|
Failures look legitimate. |
|
And overconfidence had been working out so well for me... |
|
PLS REBUILD ALL |
|
You're right about the doc comments I'm sure, but undoing other peoples' copy-pasting is not on my list of things to do more of. |
|
But I will attempt to make my original material conform. |
|
Geez, is it expected that I have to re-scaladoc the entire library to view any change? Any attempt to scaladoc Stream in isolation explodes horribly. |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/801/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1511/ |
|
jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1511/ |
|
jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/801/ |
|
PLS REBUILD ALL |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/802/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1512/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/802/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1512/ |
|
Review by @retronym |
|
Looks like it wasn't all copy/paste: a few hand crafted, Sorry to have led you down this windy path. The code changes LGTM. |
|
Maybe this is why they don't let me near documentation, but I consider redundant docs as valuable as redundant code. Does Stream#reverse really merit a Stream specific example for us to watch bitrot? It's reverse. |
|
I tend to agree with you. But it's not my area of expertise, either. I guess that "will terminate for infinite sequences" isn't an accessible description for all. I'd say the right compromise is to put a few expository examples in the class documentation. @heathermiller might have an opinion here. But until then, I would decouple the doc changes from the functional changes (other than the obviously good parts of separating implementation comments from doc comments). |
Nesting recursive calls in Stream is always a dicey business.
"There's nothing we can do about dropRight," you say? Oh but there is.
|
PLS REBUILD ALL |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/813/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1523/ |
|
jenkins job pr-rangepos: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/813/ |
|
Rogue aborter strikes again! |
|
PLS REBUILD ALL |
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/814/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/1523/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/814/ |
Fix SI-6584, Stream#distinct uses too much memory.
Nesting recursive calls in Stream is always a dicey business.