Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-6640 Better reporting of deficient classpaths. #1607

Merged
merged 3 commits into from
Nov 19, 2012

Commits on Nov 10, 2012

  1. SI-6640 Better reporting of deficient classpaths.

    In a55788e, StubSymbols were introduced to fail-slow when
    the classpath was deficient. This allowed compilation to
    succeed in cases when one didn't actually use the part of
    class A which referred to some missing class B.
    
    But a few problems were introduced.
    
    Firstly, when the deferred error eventually happened, it was
    signalled with abort(msg), rather than through a thrown
    MissingRequirementError. The latter is desirable, as it doesn't
    lead to printing a stack trace.
    
    Second, the actual error message changed, and no longer
    included the name of the class file that refers to the missing
    class.
    
    Finally, it seems that we can end up with a stub term symbol
    in a situation where a class symbol is desired. An assertion
    in the constructor of ThisType throws trips when calling .isClass,
    before the useful error message from StubSymbol can be emitted.
    
    This commit addresses these points, and rewords the error
    a little to be more accessible. The last point is the most fragile
    in this arrangement, there might be some whack-a-mole
    required to find other places that also need this.
    I don't see a clean solution for this, but am open to suggestions.
    
    We should really build a facility in partest to delete
    specified classfiles between groups in separate compilation
    tests, in order to have tests for this. I'll work on that as a followup.
    
    For now, here's the result of my manual testing:
    
    [info] Set current project to default-821d14 (in build file:/Users/jason/code/scratch1/)
    > compile
    
    [info] Compiling 1 Scala source to /Users/jason/code/scratch1/target/scala-2.10/classes...
    [error]
    [error]      while compiling: /Users/jason/code/scratch1/test.scala
    [error]         during phase: typer
    [error]      library version: version 2.10.0-RC2
    [error]     compiler version: version 2.10.0-RC2
    ...
    [error]   last tree to typer: Ident(SwingWorker)
    [error]               symbol: <none> (flags: )
    [error]    symbol definition: <none>
    [error]        symbol owners:
    [error]       context owners: object Test -> package <empty>
     ...
    [error] uncaught exception during compilation: java.lang.AssertionError
    [trace] Stack trace suppressed: run last compile:compile for the full output.
    [error] (compile:compile) java.lang.AssertionError: assertion failed: value actors
    [error] Total time: 2 s, completed Nov 10, 2012 3:18:34 PM
    >
    > set scalaHome := Some(file("/Users/jason/code/scala/build/pack"))
    [info] Defining *:scala-home
    [info] The new value will be used by no settings or tasks.
    [info] Reapplying settings...
    [info] Set current project to default-821d14 (in build file:/Users/jason/code/scratch1/)
    ^[compile
    [info] Compiling 1 Scala source to /Users/jason/code/scratch1/target/scala-2.10/classes...
    [error] /Users/jason/code/scratch1/test.scala:4: A signature in SwingWorker.class refers to term actors in package scala which is missing from the classpath.
    [error] object Test extends SwingWorker
    [error]                     ^
    [error] one error found
    [error] (compile:compile) Compilation failed
    [error] Total time: 2 s, completed Nov 10, 2012 3:18:45 PM
    retronym committed Nov 10, 2012
    Configuration menu
    Copy the full SHA
    0b59b46 View commit details
    Browse the repository at this point in the history
  2. Refine the message and triggering of MissingRequirementError.

     - To force a failure of the stub, call a new method `failIfStub`
       rather than `info`.
     - Offer a broader range of potential root causes in the
       error message.
    retronym committed Nov 10, 2012
    Configuration menu
    Copy the full SHA
    86e045e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2012

  1. SI-6440 Address regressions around MissingRequirementError

     Go back to using globalError to report when a stub's info is referenced,
     and only throw the MissingRequirementError when compilation really
     must abort due to having a StubTermSymbol in a place where a
     StubClassSymbol would have been a better choice.
    
     This situation arises when an entire package is missing from the
     classpath, as was the case in the reported bug.
    
     Adds `StoreReporterDirectTest`, which buffers messages issued
     during compilation for more structured interrogation. Use this
     in two test for manifests -- these tests were using a crude means
     of grepping compiler console output to focus on the relevant output,
     but this approach was insufficient with the new multi-line error
     message emitted as part of this change.
    
     Also used that base test class to add two new tests: one for
     the reported error (package missing), and another for a simpler
     error (class missing). The latter test shows how stub symbols
     allow code to compile if it doesn't the subset of signatures
     in some type that refer to a missing class.
    
     Gave the INFO/WARNING/ERROR members of Reporter sensible
     toString implementations; they inherit from Enumeration#Value
     in an unusual manner (why?) that means the built in toString of
     Enumeration printed `Severity@0`.
    retronym committed Nov 13, 2012
    Configuration menu
    Copy the full SHA
    0792966 View commit details
    Browse the repository at this point in the history