Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-4976 Scaladoc: Add a source link to package objects #1911

Merged
merged 1 commit into from Feb 2, 2013

Conversation

kzys
Copy link
Member

@kzys kzys commented Jan 16, 2013

If a package has a package object, the source link should point the source file of the package object.

Review by @heathermiller

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2151/

@scala-jenkins
Copy link

Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1425/

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/2151/

@scala-jenkins
Copy link

jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/1425/

@JamesIry
Copy link
Contributor

ping @heathermiller for review or naming somebody else.

@JamesIry
Copy link
Contributor

JamesIry commented Feb 1, 2013

ping @VladUreche Need some help moving this 16 day old PR forward.

@heathermiller
Copy link
Member

This seems fine to me (i.e. LGTM), and it works as advertised. But I'm not the Scaladoc model expert, I don't know if this breaks some sort of special case, so I'll let @VladUreche step in for the final LGTM.

adriaanm added a commit that referenced this pull request Feb 2, 2013
SI-4976 Scaladoc: Add a source link to package objects
@adriaanm adriaanm merged commit d4b46f6 into scala:2.10.x Feb 2, 2013
@VladUreche
Copy link
Member

Post-merge LGTM from me too, thanks Kato! :p

@kzys kzys deleted the jira-4976 branch February 3, 2013 00:46
@som-snytt
Copy link
Contributor

Just ran into this in the online docs, thanks from me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants