SI-7151 Emit final in bytecode for final inner classes. #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and submitting against 2.10.x; this was a regression from 2.9.2 to 2.10.0, so it would be nice to deliver the fix in 2.10.3. |
As we did before a regression in 18efded / SI-5676. This commit tightens up the condition in which the FINAL modifier is omitted; it now *only* does this for the module classes of nested objects.
|
@JamesIry could you please re-review now that I have targeted master? |
|
@JamesIry: ping |
|
LGTM |
gkossakowski
added a commit
that referenced
this pull request
Jun 19, 2013
SI-7151 Emit final in bytecode for final inner classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did before a regression in 18efded / SI-5676.
This commit tightens up the condition in which the FINAL
modifier is omitted; it now only does this for the module
classes of nested objects.
Review by @JamesIry