SI-7515 Emit final in bytecode for final inner classes. #2636
Conversation
As we did before a regression in 18efded / SI-5676. This commit tightens up the condition in which the FINAL modifier is ommitted; it now *only* does this for the module classes of nested objects.
|
Submitting against 2.10.x; this was a regression from 2.9.2 to 2.10.0, so it would be nice to deliver the fix in 2.10.3. |
|
I think this will be LGTM, but I want to make triple sure we're not concerned about binary compatibility issues. In particular this does create a binary incompatibility but one that will never be seen by people writing Scala. But what about people writing Java, could they have extended a final inner class that was missing the final attribute in its classfile? Do we care? |
|
If we ever cared about usage from Java, we wouldn't have |
|
@soc sealed is a compile-time feature which can't be enforced from java. This has literally zero bearing on how to assess binary-incompatible changes which can be observed from java. |
|
It is abundantly non-obvious how this PR relates to SI-7515. Oh, it's SI-7151. |
|
I am against a change like this which impacts binary compatibility, especially in the absence of any compelling motivation. If we were generating final too frequently, that would be one thing; it is harder to break things by relaxing restrictions than by tightening them. I think this should be master only. |
|
Reopened against master as #2635. And fixed my JIRA dyslexia to boot. |
…iting This check doesn?t work on Scala 2.10 due to the bug that is addressed by the following change: scala/scala#2636 The change wasn?t back-ported to 2.10 due to binary compatibility concerns. So we now don?t require a value that is being unboxed to be of a final class. This should be ok since we only unbox when a primitive argument type is expected which (we think) should only happen if the argument is an AnyVal.
As we did before a regression in 18efded / SI-5676.
This commit tightens up the condition in which the FINAL
modifier is ommitted; it now only does this for the module
classes of nested objects.
Review by @JamesIry