Various bugfixes and improvements for the quasiquotes #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for quasiquotes to implement SyntacticNew combinator.
1. Make superPos parameter optional with default value NoPosition 2. use Option instead of List for local optional constructor variable
1. blocks now match single term-level expressions to account for
automatic block elimination. E.g.
val q"{ ..$stats }" = q"foo"
will match into stats = List(q"foo"). This is useful to uniformly
deal with blocks on term level.
2. blocks in quasiquotes collapse into single expressions
3. Applied and TypeApplied now have constructors too which helps
to unify matching and extraction in quasiquote reifier
4. TypeApplied now matches AppliedTypeTree too
5. Add Syntactic prefix to Applied and TypeApplied
Syntax spec mislead me to believe that annotation can't have type parameters or multiple argument lists... I guess the lesson here is don't trust the spec.
|
Sorry I didn't have time yet for a full review, I'll do that on Monday at the latest. What I've seen so far is really well structured, great work! |
ghost
assigned
|
I think this is just about ready to go, I'd just like #2910 (comment) addressed before merging. |
|
@retronym Yep, very much agree. Great work! |
|
After some discussion, we've decided to defer the refactoring of |
|
LGTM |
retronym
added a commit
that referenced
this pull request
Sep 11, 2013
Various bugfixes and improvements for the quasiquotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following bugs:
Improves handling of the following language constructs:
And lastly:
Review by @retronym
Some discussion on the previous version of the pr.