deprecates resetAllAttrs and resetLocalAttrs in favor of the new API #3348
Conversation
ghost
assigned 
|
review @retronym |
|
Please feel free to decide whether this should go into M8 or RC1. |
| * | ||
| * Read http://stackoverflow.com/questions/20936509/scala-macros-what-is-the-difference-between-typed-aka-typechecked-an-untyped | ||
| * for more information. | ||
| */ |
There was a problem hiding this comment.
Is there any way to avoid copy-paste here? If not, a side-comment that somehow textually links the two would be helpful.
There was a problem hiding this comment.
Not sure whether there are scaladoc macros that can span multiple modules. @heathermiller @VladUreche could you help here?
There was a problem hiding this comment.
How about a link ("more details in ...") from the documentation one method to the docs of the other?
There was a problem hiding this comment.
Okay, we could link the toolbox doc (arguably, much less important) to the context doc. Will do now.
There was a problem hiding this comment.
That would work, thanks Jason! Btw, the last line:
* Read http://stackoverflow.com/questions/20936509/scala-macros-what-is-the-difference-between-typed-aka-typechecked-an-untyped
* for more information.
could also be written as:
* @see [[http://stackoverflow.com/questions/20936509/scala-macros-what-is-the-difference-between-typed-aka-typechecked-an-untyped]]
This cute little type is necessary for importers to work correctly. I wonder how we could overlook its existence for almost 2 years.
We now have c.untypecheck, which is supposed to be a counterpart of c.typecheck in the sense that it goes back from typed trees to untyped ones: http://stackoverflow.com/questions/20936509/scala-macros-what-is-the-difference-between-typed-aka-typechecked-an-untyped. Let’s hope that c.untypecheck will soon be able to solve our problems with partially/incorrectly attributed trees emitted by macros: https://groups.google.com/forum/#!topic/scala-internals/TtCTPlj_qcQ.
|
PLS REBUILD ALL |
|
PLS REBUILD ALL |
|
PLS REBUILD ALL |
|
PLS REBUILD ALL |
|
This PR seems to be particularly unlucky with the kitten. I'll close it and reopen it again. |
We now have c.untypecheck, which is supposed to be a counterpart of c.typecheck
in the sense that it goes back from typed trees to untyped ones:
http://stackoverflow.com/questions/20936509/scala-macros-what-is-the-difference-between-typed-aka-typechecked-an-untyped.
Let’s hope that c.untypecheck will soon be able to solve our problems
with partially/incorrectly attributed trees emitted by macros:
https://groups.google.com/forum/#!topic/scala-internals/TtCTPlj_qcQ.