SI-8215: Correcting typo and splitting a long sentence in MatchIterator doc #3470
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or doc Follow-up to 9c0ca62
|
LGTM No worries, I appreciate the attention to detail! |
|
@adriaanm Anything else you need from me on this one..? |
|
Nope, merging! |
adriaanm
added a commit
that referenced
this pull request
Feb 10, 2014
SI-8215: Correcting typo and splitting a long sentence in MatchIterator doc
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 9c0ca62. The typo comes from the fact that I didn't take into account the full rendering of exception names:
Also taken the opportunity to split a sentence that seems a bit long into two.
Review by @adriaanm @heathermiller
Sorry that we need this fixup!