SI-8875 showCode should print all class constructor modifiers. #4045
Conversation
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 58636343) |
|
PLS REBUILD/pr-scala@037f295 |
|
(kitty-note-to-self: ignore 58663584) |
|
PLS REBUILD/pr-scala@037f295 |
|
(kitty-note-to-self: ignore 58740406) |
gourlaysama
force-pushed
the
wip/t8875-show-code
branch
from
037f295
to
ee5a5d1
Compare
|
PLS REBUILD/pr-scala@ee5a5d1 |
|
(kitty-note-to-self: ignore 58883103) |
|
PLS REBUILD ALL |
| @@ -761,7 +761,7 @@ trait Printers extends api.Printers { self: SymbolTable => | |||
| val build.SyntacticClassDef(_, _, _, ctorMods, vparamss, earlyDefs, parents, selfType, body) = cl | |||
|
|
|||
| // constructor's modifier | |||
| if (ctorMods.hasFlag(AccessFlags)) { | |||
| if (ctorMods.hasFlag(AccessFlags) || ctorMods.privateWithin != tpnme.EMPTY) { | |||
There was a problem hiding this comment.
ctorMods.hasAccessBoundary is a higher level way of saying the same thing.
There was a problem hiding this comment.
Thanks, I missed that one. Fixed.
showCode used to print nothing when the only modifier was a change in visibility scope (i.e. no flags but privateWithin is set).
gourlaysama
force-pushed
the
wip/t8875-show-code
branch
from
ee5a5d1
to
f8d1a9f
Compare
|
Triggering rebuild now that IDE validation should be fixed. Sorry about all the noise. |
|
(kitty-note-to-self: ignore 59266442) |
|
LGTM |
SI-8875 showCode should print all class constructor modifiers.
showCode used to print nothing when the only modifier was a change in
visibility scope (i.e. no flags but privateWithin is set).