New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nomerge] SI-8899 Revert "SI-8627 make Stream.filterNot non-eager" #4048

Merged
merged 1 commit into from Oct 20, 2014

Conversation

Projects
None yet
3 participants
@lrytz
Copy link
Member

lrytz commented Oct 12, 2014

This reverts commit 9276a12.

The change is not binary compatible, See discussion on SI-8899. Making
filterImpl non-private changes its call-sites (within TraversableLike)
from INVOKESTATIC to INVOKEINTERFACE. Subclasses of TraversableLike
compiled before this change don't have a mixin for filterImpl.

[nomerge] SI-8899 Revert "SI-8627 make Stream.filterNot non-eager"
This reverts commit 9276a12.

The change is not binary compatible, See discussion on SI-8899. Making
filterImpl non-private changes its call-sites (within TraversableLike)
from INVOKESTATIC to INVOKEINTERFACE. Subclasses of TraversableLike
compiled before this change don't have a mixin for filterImpl.
@lrytz

This comment has been minimized.

Copy link
Member Author

lrytz commented Oct 14, 2014

PLS REBUILD/pr-scala@38587c5

@scala-jenkins

This comment has been minimized.

Copy link

scala-jenkins commented Oct 14, 2014

(kitty-note-to-self: ignore 59030173)
🐱 Roger! Rebuilding pr-scala for 38587c5. 🚨

@gkossakowski

This comment has been minimized.

Copy link
Member

gkossakowski commented Oct 20, 2014

LGTM

gkossakowski added a commit that referenced this pull request Oct 20, 2014

Merge pull request #4048 from lrytz/t8899
[nomerge] SI-8899 Revert "SI-8627 make Stream.filterNot non-eager"

@gkossakowski gkossakowski merged commit 767cc44 into scala:2.11.x Oct 20, 2014

1 check passed

default pr-scala Took 68 min.
Details

@lrytz lrytz deleted the lrytz:t8899 branch Nov 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment