-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-3809 Avoid cycles during classfile parsing #5308
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retronym
changed the title
WIP SI-3809 Avoid cycles during classfile parsing
WIP SI-3809 Avoid cycles during classfile parsing [ci: lastOnly]
Jul 28, 2016
/rebuild |
retronym
force-pushed
the
ticket/3809
branch
2 times, most recently
from
July 28, 2016 12:22
32b803c
to
b1c90e0
Compare
retronym
changed the title
WIP SI-3809 Avoid cycles during classfile parsing [ci: lastOnly]
WIP SI-3809 Avoid cycles during classfile parsing [ci: last-only]
Jul 28, 2016
retronym
force-pushed
the
ticket/3809
branch
6 times, most recently
from
November 21, 2016 13:29
2061985
to
736765a
Compare
retronym
force-pushed
the
ticket/3809
branch
from
November 29, 2016 06:53
736765a
to
2040a98
Compare
Manually tested with: ``` scalaHome := Some(file("/code/scala/build/pack")) libraryDependencies += "com.datastax.cassandra" % "dse-driver" % "1.0.0" ``` ``` class Test { new com.datastax.driver.dse.DseCluster.Builder() } ``` I was also able to compile `pos/cycle{-jsoup,}` without the experimental `-Ybreak-cycles`. I've removed the entire `-Ybreak-cycles` option and supporting code in favour of the approach in this patch. What's changed? I've used lazy types for methods infos, which is analagous to what we do in `Unpickler` for scala originated types.
retronym
force-pushed
the
ticket/3809
branch
from
November 29, 2016 07:29
2040a98
to
7d65228
Compare
retronym
changed the title
WIP SI-3809 Avoid cycles during classfile parsing [ci: last-only]
SI-3809 Avoid cycles during classfile parsing [ci: last-only]
Nov 29, 2016
retronym
changed the title
SI-3809 Avoid cycles during classfile parsing [ci: last-only]
SI-3809 Avoid cycles during classfile parsing
Nov 29, 2016
I've realized that the addition of laziness here will increase the footprint: the I've just pushed a WIP commit to might alleviate this problem. |
retronym
force-pushed
the
ticket/3809
branch
from
December 12, 2016 03:49
d3464aa
to
d9e22cb
Compare
This is also occuring on dotty. scala/scala3#9492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested with:
I was also able to compile
pos/cycle{-jsoup,}
without the experimental-Ybreak-cycles
. I've removed the entire-Ybreak-cycles
option andsupporting code in favour of the approach in this patch.
What's changed? I've used lazy types for methods infos, which is analagous
to what we do in
Unpickler
for scala originated types.