Issue/4717 #576
Merged
Issue/4717 #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 15, 2012 15:50
A lazy val declared inside an anonymous class inside a specialized
context no longer crashes Duplicators.
Previously, a duplicated lazy val was assigned to the wrong owner
in Duplicators:
def x[B >: A]: Unit = new Bounds[B] {
lazy val it = ??? // def or val okay
}
Above, the `it` in `$anon` in `x$mcZ$sp` had its owner set to `x$mcZ$sp`
instead of `$anon`. This crashed the typer when it had to retype its
lazy accessor, because there was no `lazy var it` in `$anon$`.
Furthermore, the duplicated symbol wasn't being added to the list of
declarations of `$anon`.
Changes:
1) `invalidate` in Duplicators takes an additional parameter which is
the new owner of the new symbol that has to be duplicated. If this parameter
is set to `NoSymbol`, then the new owner is `context.owner`, as before.
2) the newly created lazy val symbol is being added to the list of
declarations of its new owner.
Removes debugging output from the previous commit.
Review by dragos.
@mention dragos
Only adding a lazy val into list of declarations if the owner is a class. Review by dragos. @mention dragos
Should be checking if the owner of the new symbol is a class, not the new symbol itself.
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/124/ |
|
Looks good to me! Thanks! |
adriaanm
added a commit
that referenced
this pull request
May 21, 2012
Fix SI-4717: lazy val declared inside an anonymous class inside a specialized context no longer crashes Duplicators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SI-4717.
A lazy val declared inside an anonymous class inside a specialized
context no longer crashes Duplicators.
Previously, a duplicated lazy val was assigned to the wrong owner
in Duplicators:
Above, the
itin$anoninx$mcZ$sphad its owner set tox$mcZ$spinstead of
$anon. This crashed the typer when it had to retype itslazy accessor, because there was no
lazy var itin$anon.Furthermore, the duplicated symbol wasn't being added to the list of
declarations of
$anon.Changes:
invalidatein Duplicators takes an additional parameter which isthe new owner of the new symbol that has to be duplicated. If this parameter
is set to
NoSymbol, then the new owner iscontext.owner, as before.declarations of its new owner, provided that the owner is a class.
Review by dragos.
@mention dragos
review by @dragos