scala/bug#1503. Don't assume unsound type for ident/literal patterns #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala/bug#1503 scala#3559 stopped assuming unsound type for ident/literal patterns under -Xfuture in Scala 2.11. Since enough time has elapsed, I am ripping the bandaid off on SI-1503 (scala/bug#1503).
5 tasks
adriaanm
approved these changes
Apr 10, 2018
|
I'm going to let this one simmer for a few more days, to make sure we're comfortable with this change in a library release. In principle, I'm in favor. |
lrytz
approved these changes
Apr 11, 2018
SethTisue
approved these changes
Apr 17, 2018
|
It doesn't seem out-of-bounds to me for 2.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#1503
This is part 4 of -Xfuture plot line cleanup.
#3559 stopped assuming unsound type for ident/literal patterns under -Xfuture in Scala 2.11.
Since enough time has elapsed, I am ripping the bandaid off on SI-1503 (scala/bug#1503). Note that return type of some code may change.