Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce PartialFunction.apply as PartialFunction.fromFunction #6703

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Reintroduce PartialFunction.apply as PartialFunction.fromFunction #6703

merged 1 commit into from
Jun 1, 2018

Conversation

Jasper-M
Copy link
Contributor

Follow up of #6005.
Opinions? @nafg @sarahgerweck @adriaanm @lrytz

@scala-jenkins scala-jenkins added this to the 2.13.0-M5 milestone May 31, 2018
nafg
nafg reviewed May 31, 2018
View reviewed changes
Copy link
Contributor

@nafg nafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I think the comment reads better without the words "Note that"

dwijnand
dwijnand approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "Note that" makes it clearer.

I would've called it "fromFunction1" but this LGTM to merge as is.

@dwijnand dwijnand merged commit f16eacc into scala:2.13.x Jun 1, 2018
@dwijnand
Copy link
Member

dwijnand commented Jun 1, 2018

Thanks @Jasper-M!

@dwijnand dwijnand added the release-notes worth highlighting in next release notes label Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafg nafg nafg left review comments

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.0-M5
Development

Successfully merging this pull request may close these issues.
4 participants
@Jasper-M @dwijnand @nafg @scala-jenkins