By-name implicits: Align detection of implicit recursion with the SIP #7368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins green, Travis-CI red, and I don't see any error details in the Travis-CI log?! |
|
This one appears to be a failed fetch of a binary artefact from a lightbend repo. I've restarted the job ... fingers X'd it's transient. |
|
Green on Travis now ... it was a transient. |
5 tasks
|
@adriaanm this is good to go now ... |
milessabin
force-pushed
the
topic/more-byname-fixes
branch
from
d4e7317
to
94a0cca
Compare
|
Rebased. |
|
One more quick rebase and will merge this one too. |
The by-name implicits SIP specifies that a recursive occurence of an implicit should tie the knot if there is at least one by-name parameter between the outermost and the innermost occurrence. Prior to this commit the implementation required that either the innermost or the outermost occurrence must be by-name. This commit brings the implementation into line with the SIP.
milessabin
force-pushed
the
topic/more-byname-fixes
branch
from
94a0cca
to
c42cd49
Compare
|
Rebased. |
|
All green. |
|
Thanks! |
SethTisue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The by-name implicits SIP specifies that a recursive occurrence of an implicit should tie the knot if there is at least one by-name parameter between the outermost and the innermost occurrence.
Prior to this commit the implementation required that either the innermost or the outermost occurrence must be by-name.
This commit brings the implementation into line with the SIP.