SI-6035 - retain specialized flag in separate compilation. #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution does not pickle the `specialize` flag on the symbol of the specialized type parameter. Instead, it recreates the `specialize` flag on a type parameter during the unpickling process if it sees the specialize annotation on that type parameter.
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/488/ |
|
jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/488/ |
|
Ok. It's also possible that we could just check the |
|
This is now superseded by #890 |
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
Jul 13, 2023
Make xsbt.CompilerInterface class name configurable Rewritten from sbt/zinc@951c722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution does not pickle the
specializeflag on the symbol of thespecialized type parameter.
Instead, it recreates the
specializeflag on a type parameter during theunpickling process if it sees the specialize annotation on that type parameter.
After rebasing the commits against head, lets hope the stability test passes this time.
In the manual checkin it looks pretty stable to me:
https://scala-webapps.epfl.ch/jenkins/job/scala-checkin-manual/205/console
Review by @gkossakowski