Improve exception thrown by Source.fromResource #9054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM as-is. |
|
I agree with Lukas that the test you already added is sufficient. Thank you! |
SethTisue
added
the
library:base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11743
Improves the exception message a bit. Adds a basic method call test.
I unfortunately orphaned PR #8443. This is the replacement.
I need pointers about two things:
I want to write a test that (1) creates two classloader instances A & B each with its own resources path, then (2) call
Source.fromResource('file_in_B.txt', classLoaderA). I wanted to test the case where it should throw the exception if the resource exists but not in the given resource path.I'm trying MissingResourceException instead, but I don't know what to use to fill in the
classNameandkeyarguments.