Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @nowarn for certain warning types (use Run reporter for wconf) #9443

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix @nowarn for certain warning types (use Run reporter for wconf) #9443

merged 1 commit into from
Jan 20, 2021

Conversation

som-snytt
Copy link
Contributor

@scala-jenkins scala-jenkins added this to the 2.12.14 milestone Jan 20, 2021
dwijnand
dwijnand approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Som.

@lrytz lrytz merged commit fdb8881 into scala:2.12.x Jan 20, 2021
@som-snytt som-snytt deleted the issue/12315 branch January 20, 2021 11:59
@SethTisue
Copy link
Member

How bad a bug was this? Does it create pressure to do 2.12.14?

@SethTisue
Copy link
Member

SethTisue commented Jan 20, 2021 •
edited
Loading

How bad a bug was this? Does it create pressure to do 2.12.14?

Dale answered this at team meeting: it's not that bad. I updated the bug title to be clearer about this.

@SethTisue SethTisue changed the title Use Run reporter for wconf Fix @nowarn for certain warning types (use Run reporter for wconf) Jan 20, 2021
@retronym retronym mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.14
Development

Successfully merging this pull request may close these issues.
5 participants
@som-snytt @SethTisue @dwijnand @lrytz @scala-jenkins