-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow $ escaping double quotes in interpolations #9536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnhoekstra
force-pushed
the
escdollar3
branch
from
March 8, 2021 09:54
51e25c5
to
be864c3
Compare
Gonna merge conflict with #8830. |
lrytz
reviewed
Mar 8, 2021
martijnhoekstra
force-pushed
the
escdollar3
branch
2 times, most recently
from
March 8, 2021 16:35
9f07b42
to
fedd2c9
Compare
martijnhoekstra
force-pushed
the
escdollar3
branch
from
March 10, 2021 19:12
fedd2c9
to
07bdc97
Compare
lrytz
force-pushed
the
escdollar3
branch
2 times, most recently
from
March 17, 2021 13:27
5ddf824
to
84c7d79
Compare
lrytz
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
lrytz
changed the title
allow $ escaping double quotes in interpolations under -Xsource:3
allow $ escaping double quotes in interpolations
May 17, 2021
julienrf
added a commit
to scalacenter/docs.scala-lang
that referenced
this pull request
May 3, 2022
Assigned number 37 to SIP “Quote escapes for interpolations”. Implemented in Scala 2.13.6 in scala/scala#9536 Implemented in Scala 3.0.0 in scala/scala3#7486
julienrf
added a commit
to scala/improvement-proposals
that referenced
this pull request
Jun 9, 2022
Assigned number 37 to SIP “Quote escapes for interpolations”. Implemented in Scala 2.13.6 in scala/scala#9536 Implemented in Scala 3.0.0 in scala/scala3#7486
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @som-snytt, making compatibility between scala2 and scala3 easier.
cf.